Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove wget as it's now not used anymore #280

Closed
wants to merge 1 commit into from

Conversation

shawaj
Copy link
Member

@shawaj shawaj commented Jan 6, 2022

Issue

How

Healthcheck not fully supported by balena yet so we don't need wget at the moment in container

Screenshots

References

ccaa8e4

Checklist

  • Tests added
  • Cleaned up commit history (rebase!)
  • Documentation added
  • Thought about variable and method names

Healthcheck not fully supported by balena yet so we don't need wget at the moment in container
@shawaj shawaj requested a review from a team as a code owner January 6, 2022 03:28
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vpetersson
Copy link
Contributor

I'd leave it in. Not a big dependency. It's useful for debugging since we don't have curl.

@shawaj
Copy link
Member Author

shawaj commented Jan 6, 2022

Ok doky @vpetersson closing for now

@shawaj shawaj closed this Jan 6, 2022
@shawaj shawaj deleted the shawaj/wgetlost branch August 28, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants