Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output warning instead of fail if a dependency could not be found #104

Merged
merged 2 commits into from
May 5, 2022

Conversation

Nef10
Copy link
Owner

@Nef10 Nef10 commented May 3, 2022

In case a dependency is not required on all platforms, it might not
be defined - in this case show a warning instead of fail.

In case a dependency is not required on all platforms, it might not
be defined - in this case show a warning instead of fail.
@Nef10 Nef10 enabled auto-merge (rebase) May 3, 2022 03:37
@Nef10 Nef10 disabled auto-merge May 3, 2022 03:42
@github-actions
Copy link

github-actions bot commented May 3, 2022

Coverage after merging warning into main

75.09%

Coverage Report
FileStmtsFuncsLinesUncovered Lines
Sources/SwiftDependencyUpdaterLibrary
   Dependency.swift52.81%60%51.90%46–64
   PackageDescription.swift71.68%69.23%72%100–104, 121–123, 134–136, 162–174, 184, 99
   ResolvedPackage.swift94.20%100%93.55%118, 23, 85, 95
   SwiftDependencyUpdater.swift100%100%100%
   SwiftPackage.swift94.94%83.33%95.89%69, 75
   SwiftPackageUpdate.swift79.45%100%77.27%41, 50, 54, 58–69
   Update.swift58.23%75%57.33%41, 43–73
Sources/SwiftDependencyUpdaterLibrary/Extensions
   Collection.swift100%100%100%
   String.swift100%100%100%
   Version.swift0%0%0%11–17, 19–32, 36–43
Sources/SwiftDependencyUpdaterLibrary/Services
   Git.swift88%83.33%88.89%62–64, 71–74
   GitHub.swift71.88%80%71.19%61, 64, 68–79, 84–86
Sources/SwiftDependencyUpdaterLibrary/SubCommands
   GitHubCommand.swift82.61%37.50%86.90%48–53
   ListCommand.swift78.38%20%87.50%
   UpdateCommand.swift65.96%20%71.43%22–27, 33–34

@Nef10 Nef10 merged commit df6e696 into main May 5, 2022
@Nef10 Nef10 deleted the warning branch May 5, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant