Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature compoent modal popup #531

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

xiangxiong
Copy link

issues:
#530

这个功能解决了什么问题?
在当前页面完善信息,可以通过参数配置弹窗的位置,支持底部和顶部弹出。
场景1: 点击领取优惠券完善用户信息,在当前页面在底部弹出弹框,用户填写。
场景2: 在商品详情页,点击购买,在底部弹出选择类目。

你期望的功能是怎样的?
1、如何使用?
新增参数:
pop 是否弹窗模式 默认值:false
animationType 弹窗位置 slide-up / slide-down 默认值:slide-up

@koppthe
Copy link
Collaborator

koppthe commented Apr 17, 2019

感谢 PR,但测试用例通不过哦
这个 Popup 抽成一个新的组件是否更合适呢?

@xiangxiong
Copy link
Author

好的,我单独抽成一个popup 组件吧。

@koppthe koppthe self-requested a review August 30, 2019 02:35
@koppthe koppthe self-assigned this Aug 30, 2019
@luckymore
Copy link
Contributor

@xiangxiong 抽完了么老哥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants