fix(transformer): 在 JSX 中用到源于 this.state 的对象没有加入 usedState，close #1492

NervJS · Dec 17, 2018 · 9bec112 · 9bec112
1 parent a2ca3b9
commit 9bec112
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/eslint-plugin-taro/__tests__/no-jsx-in-class-method.js b/packages/eslint-plugin-taro/__tests__/no-jsx-in-class-method.js
@@ -36,12 +36,12 @@ ruleTester.run('no-jsx-in-class-method', rule, {
       }
       return <View />
     })`
-  ]),
+  ]).com,
   invalid: testInvalid(ERROR_MESSAGE, [
     `
     class App extends Component {
-      _render() {
-        return <View />
+      test(a) {
+        return a.map(_ => <View />)
       }
     }
     `,

diff --git a/packages/taro-transformer-wx/src/class.ts b/packages/taro-transformer-wx/src/class.ts
@@ -349,7 +349,7 @@ class Transformer {
             const sibling = path.getSibling('property')
             if (
               path.get('object').isThisExpression() &&
-              path.get('property').isIdentifier({ name: 'props' }) &&
+              (path.get('property').isIdentifier({ name: 'props' }) || path.get('property').isIdentifier({ name: 'state' })) &&
               sibling.isIdentifier()
             ) {
               const attr = path.findParent(p => p.isJSXAttribute()) as NodePath<t.JSXAttribute>