Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(harmony): input组件用作radio时,同一group的item,name必须相同,这里使用groupId作为name #10843

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

troy-sxj
Copy link
Collaborator

@troy-sxj troy-sxj commented Dec 8, 2021

这个 PR 做了什么? (简要描述所做更改)

修复harmony radio组件无法切换问题

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙

@taro-bot2
Copy link

taro-bot2 bot commented Dec 8, 2021

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

@troy-sxj troy-sxj marked this pull request as ready for review December 8, 2021 04:01
@Chen-jj Chen-jj added the T-harmony Target - 编译到 Harmony label Dec 8, 2021
@Chen-jj Chen-jj merged commit 2be3f9b into NervJS:feat/harmony Dec 8, 2021
Chen-jj pushed a commit that referenced this pull request Feb 7, 2022
* fix(harmony): 优化 input 组件对 name 属性的处理 (#10843)

* fix(harmony): input组件用作radio时,同一group的item,name必须相同,这里使用groupId作为name

* fix(harmony): radio组件name属性优先级处理:优先取groupId,groupId为空时使用name

Co-authored-by: shangxiaojian <[email protected]>

* feat: media开发

* feat: media getImageInfo 开发

* feat: image compressImage开发

* feat: image compressImage开发

* feat: image previewImage开发

* feat: media video,image开发

* feat: media-video开发

* feat: media-video开发

* feat: media-preview media开发

* feat:  media-choose media开发

* feat:  media-choose media开发

* feat: media调试

* feat: media chooseVideo,chooseImage调试

* feat: media api

* feat: media api 删除调试代码

* feat: 取消注释

Co-authored-by: shangxiaojian <[email protected]>
Co-authored-by: shangxiaojian <[email protected]>
Co-authored-by: xueshuai7 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-harmony Target - 编译到 Harmony
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants