Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 修复 pageId 装载和卸载逻辑不一致的问题 #14179

Merged
merged 6 commits into from
Jul 24, 2023
Merged

fix: 修复 pageId 装载和卸载逻辑不一致的问题 #14179

merged 6 commits into from
Jul 24, 2023

Conversation

xuanzebin
Copy link
Member

这个 PR 做了什么? (简要描述所做更改)

  • 修复 pageId 装载和卸载逻辑不一致的问题

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix this.getPageId is not a function #14127
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）
  • 鸿蒙（harmony）

@xuanzebin xuanzebin requested a review from Chen-jj July 14, 2023 09:10
@taro-bot2 taro-bot2 bot mentioned this pull request Jul 15, 2023
Closed
Chen-jj
Chen-jj requested changes Jul 21, 2023
View reviewed changes
packages/taro-runtime/src/dsl/common.ts Outdated Show resolved Hide resolved
packages/taro-runtime/src/dsl/common.ts Show resolved Hide resolved
@taro-bot2 taro-bot2 bot mentioned this pull request Jul 22, 2023
Closed
@xuanzebin xuanzebin merged commit d61d786 into next Jul 24, 2023
@xuanzebin xuanzebin deleted the fix/pageid branch July 24, 2023 05:44
yechunxi pushed a commit to yechunxi/taro that referenced this pull request Aug 4, 2023
@xuanzebin @yechunxi
fix: 修复 pageId 装载和卸载逻辑不一致的问题 (NervJS#14179)
90d1e8d 
* fix: 修复 pageId 装载和卸载逻辑不一致的问题

* fix: 修复 pageid 挂载错误的逻辑

* refactor: 删除无用代码

---------

Co-authored-by: xuanzebin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chen-jj Chen-jj Chen-jj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

this.getPageId is not a function
2 participants
@xuanzebin @Chen-jj