Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 增加navigationStyle配置处理逻辑 #14960

Merged

Conversation

guoenxuan
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)

  • 增加navigationStyle配置项的处理逻辑trigger __taroSetNavigationStyle事件
  • spa应用的页面加载时,生命周期触发顺序改为 page.onShow >> page.onReady

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

packages/taro-router/src/router/page.ts Show resolved Hide resolved
packages/taro-router/src/router/page.ts Show resolved Hide resolved
packages/taro-router/src/router/page.ts Outdated Show resolved Hide resolved
packages/taro-router/src/router/page.ts Show resolved Hide resolved
@guoenxuan guoenxuan force-pushed the mpharmony-gex-navigation-style branch 2 times, most recently from 91ef8f0 to 1c31486 Compare December 26, 2023 09:13
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Merging #14960 (b7be19a) into main (3633375) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14960   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files           9        9           
  Lines         646      646           
  Branches      123      123           
=======================================
  Hits          522      522           
  Misses        110      110           
  Partials       14       14           

@ZakaryCode ZakaryCode merged commit 40a8d75 into NervJS:main Dec 26, 2023
13 checks passed
ZakaryCode added a commit that referenced this pull request Dec 29, 2023
* feat: 增加navigationStyle配置处理逻辑

* Update page.ts

---------

Co-authored-by: Zakary <[email protected]>
ZakaryCode added a commit that referenced this pull request Jan 15, 2024
* feat: 增加navigationStyle配置处理逻辑

* Update page.ts

---------

Co-authored-by: Zakary <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-h5 Target - 编译到 H5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants