Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(weapp): support skyline components #15268

Closed
wants to merge 4 commits into from

Conversation

TheKonka
Copy link
Member

#14698

这个 PR 做了什么? (简要描述所做更改)
完善对微信小程序skyline组件的支持

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix 微信小程序skyline新增标签功能支持 #14698
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.82%. Comparing base (134812f) to head (73ed98d).
Report is 4 commits behind head on main.

❗ Current head 73ed98d differs from pull request most recent head bbdb3d4. Consider uploading reports for the commit bbdb3d4 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #15268      +/-   ##
==========================================
+ Coverage   58.53%   58.82%   +0.28%     
==========================================
  Files         491      490       -1     
  Lines       21882    21764     -118     
  Branches     5621     5587      -34     
==========================================
- Hits        12808    12802       -6     
+ Misses       7909     7782     -127     
- Partials     1165     1180      +15     
Flag Coverage Δ
taro-cli 63.29% <ø> (+5.88%) ⬆️
taro-runner 46.21% <ø> (-0.05%) ⬇️
taro-runtime 65.51% <ø> (+0.16%) ⬆️
taro-web 40.88% <100.00%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...kages/taro-components/src/components/span/span.tsx 100.00% <100.00%> (ø)

... and 34 files with indirect coverage changes

@Chen-jj Chen-jj self-requested a review March 13, 2024 07:48
@BoneTM
Copy link
Contributor

BoneTM commented Apr 4, 2024

any progress?

This was referenced Apr 6, 2024
@koppthe koppthe self-requested a review April 16, 2024 15:17
@koppthe koppthe closed this Apr 18, 2024
@TheKonka TheKonka deleted the fix/skyline-components branch April 18, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

微信小程序skyline新增标签功能支持
3 participants