fix: [H5] tab组件安全区域避让适配 #15862
Closed
fix: [H5] tab组件安全区域避让适配 #15862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #15862 +/- ##
======================================
Coverage ? 56.51%
======================================
Files ? 500
Lines ? 22767
Branches ? 5645
======================================
Hits ? 12866
Misses ? 8666
Partials ? 1235
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Jun 15, 2024
This was referenced Jul 6, 2024
yoyo837
reviewed
Jul 8, 2024
| @@ -41,7 +41,8 @@ body { | |||
| &__tabbar { | |||
| position: relative; | |||
| width: 100%; | |||
| height: var(--taro-tabbar-height); | |||
| height: calc(var(--taro-tabbar-height) + constant(safe-area-inset-bottom)); | |||
| height: calc(var(--taro-tabbar-height) + env(safe-area-inset-bottom)); | |||
There was a problem hiding this comment.
增加height底部颜色和tabbar一致，视觉效果更舒服没有割裂感
There was a problem hiding this comment.
padding应该也会一致吧？而且不用关心本身的高度
There was a problem hiding this comment.
padding不用关系本身的高度？
There was a problem hiding this comment.
请仔细看一看tabbar的实现，如果加padding tabbar高度是不会变，这种后果要么是无法避让安全区域导航条和tabbar item重叠要么tabbar里的item顶到tabbar最上方显示。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
原tab组件适配安全区域时有以下几点错误：
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台: