Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(taro-swan): remove unnecessary judge #1612

Closed
wants to merge 1 commit into from
Closed

chore(taro-swan): remove unnecessary judge #1612

wants to merge 1 commit into from

Conversation

suyingtao
Copy link

The value of hasPageInited always equal ture when variable isPage equal true. Then the value of hasPageInited || isPage always equal hasPageInited , so isPage is unnecessary.

@luckyadam luckyadam self-requested a review December 20, 2018 06:29
@taro-bot taro-bot bot mentioned this pull request Dec 22, 2018
Closed
@taro-bot taro-bot bot mentioned this pull request Dec 29, 2018
Closed
@taro-bot taro-bot bot mentioned this pull request Jan 12, 2019
Closed
This was referenced Jan 19, 2019
Closed
Closed
@Littly Littly force-pushed the master branch 2 times, most recently from 23c5d8e to 689ecc9 Compare January 29, 2019 13:04
@taro-bot taro-bot bot mentioned this pull request Feb 2, 2019
Closed
@taro-bot taro-bot bot mentioned this pull request Feb 23, 2019
Closed
@taro-bot taro-bot bot mentioned this pull request Mar 9, 2019
Closed
@taro-bot taro-bot bot mentioned this pull request Mar 16, 2019
Closed
@taro-bot taro-bot bot mentioned this pull request Mar 30, 2019
Closed
@taro-bot taro-bot bot mentioned this pull request Apr 20, 2019
Closed
@taro-bot taro-bot bot mentioned this pull request May 25, 2019
Closed
@luckyadam luckyadam closed this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luckyadam luckyadam Awaiting requested review from luckyadam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@suyingtao @luckyadam