Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taro-vite-runner): 修复 vite h5 dev & build 路径未转 posix 导致的异常 #16124

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

weizs
Copy link
Contributor

@weizs weizs commented Jul 18, 2024

这个 PR 做了什么? (简要描述所做更改)
windows 环境下,vite h5 dev 和 build 时候,resolveId 根据 configPath 判断是否 app.config.ts,但 resolve 后的路径为 posix,configPath 未转换,导致逻辑失效。

这里将 configPath 路径进行转换,同时对 dev 模式下生成 code 路径进行转换,避免 dev 解析失效

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

taro-bot2 bot commented Jul 18, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.03%. Comparing base (e0bbb17) to head (159cb96).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16124      +/-   ##
==========================================
- Coverage   61.05%   61.03%   -0.03%     
==========================================
  Files         445      445              
  Lines       22939    22939              
  Branches     5022     4966      -56     
==========================================
- Hits        14005    14000       -5     
- Misses       7957     8127     +170     
+ Partials      977      812     -165     
Flag Coverage Δ
taro-cli 73.67% <ø> (ø)
taro-runtime 59.83% <ø> (ø)
taro-web 52.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 34 files with indirect coverage changes

@ZEJIA-LIU ZEJIA-LIU merged commit 4558798 into NervJS:main Jul 25, 2024
23 checks passed
This was referenced Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants