Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taro-cli): fix taro weapp watch entry file #2222

Closed
wants to merge 1 commit into from

Conversation

pamler
Copy link
Contributor

@pamler pamler commented Feb 20, 2019

修改微信小程序监听文件修改时,判断是否是entryFile的bug。原判断如果文件路径中任何一个地方出现了app字符串,那么都会认为是entryFile。例如 xxx/xx/logApproval/xxx这个path,会被错误的认为是entryFile

@luckyadam
Copy link
Member

这里要考虑下使用 ts 的情况

@pamler
Copy link
Contributor Author

pamler commented Feb 20, 2019

那就是 path.basename(filePath, extname),是这个意思么?

修改微信小程序监听文件修改时,判断是否是entryFile的bug
@pamler pamler force-pushed the fix-taro-weapp-watch-entryfile branch from 8873892 to f2ff8c1 Compare February 21, 2019 06:09
@luckyadam
Copy link
Member

感觉这个判断不行,改成直接对比文件路径吧~

@luckyadam
Copy link
Member

aa9e657
这样改吧

@luckyadam luckyadam closed this Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants