Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 新增--buildVersion，便于修改outputDir #3564

Closed
wants to merge 2 commits into from
Closed

feat: 新增--buildVersion，便于修改outputDir #3564

wants to merge 2 commits into from

Conversation

itsonglei
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)
cli 新增--buildVersion，便于在命令行中直接修改 h5: outputDir

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • [ x ] 提交到 master 分支
  • [ x ] Commit 信息遵循 Angular Style Commit Message Conventions
  • [ x ] 所有测试用例已经通过
  • [ x ] 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • [ x ] 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • [ x ] Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@taro-bot taro-bot bot mentioned this pull request Jun 29, 2019
Closed
Garfield550
Garfield550 reviewed Jul 1, 2019
View reviewed changes
Copy link
Collaborator

@Garfield550 Garfield550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 如果 --buildVersion 的目的只是修改 outputDir 的话不如把这个选项直接改成 --outputDir。

  2. 你的 PR 只为 H5 提供了该功能，用户在小程序端或者 RN 端无法使用这个功能。

  3. 新功能的 PR 建议包含文档更新和示例用法。

@luckyadam
Copy link
Member

这个功能可以通过编译时设置环境变量来实现的，感觉不用这样改动

Garfield550
Garfield550 requested changes Jul 1, 2019
View reviewed changes
Copy link
Collaborator

@Garfield550 Garfield550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请不要对无关的文件进行改动，如果需要测试，请编写测试用例。

@itsonglei
Copy link
Contributor Author

嗯嗯，明白

@itsonglei itsonglei closed this Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield550 Garfield550 Garfield550 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsonglei @luckyadam @Garfield550