Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Picker组件需要为iOS8添加webkit前缀 #4519

Merged
merged 1 commit into from
Sep 24, 2019
Merged

fix: Picker组件需要为iOS8添加webkit前缀 #4519

merged 1 commit into from
Sep 24, 2019

Conversation

zhouchengi
Copy link
Contributor

@zhouchengi zhouchengi commented Sep 23, 2019 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)
修复了picker在iOS8下无法滑动的问题，增加webkit前缀即可，希望官方在其他组件也注意下webkit前缀的添加

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@zhouchengi zhouchengi changed the title fix: iOS8需要添加webkit前缀 fix: Picker组件需要为iOS8添加webkit前缀 Sep 23, 2019
@luckyadam luckyadam merged commit 08d0a3c into NervJS:master Sep 24, 2019
@taro-bot taro-bot bot mentioned this pull request Sep 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhouchengi @luckyadam