Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 修复模板在h5下莫名变量 #4746

Closed
wants to merge 6 commits into from
Closed

Conversation

archiewx
Copy link

@archiewx archiewx commented Nov 2, 2019

这个 PR 做了什么? (简要描述所做更改)

修复h5模板莫名变量

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

其它需要 Reviewer 或社区知晓的内容:

@archiewx
Copy link
Author

archiewx commented Nov 2, 2019

第二个是我根据chrome-devtools观察得到:
对比文件:

使用charles 进行本地文件map进行比较:
image
这是 使用 clientWidth 情况 index2.html

image
这是使用index.html 情况, 对应代码:
image
通过源码:https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/element.cc?dr=CSs&sq=package:chromium&g=0&l=1880

以及stackoverflow讨论: https://stackoverflow.com/questions/13234214/reflow-layout-performance-for-large-application

这里如果仅仅获取宽度,使用clientWidth 即可。可能认识有误,欢迎反馈

@archiewx
Copy link
Author

archiewx commented Nov 5, 2019

@luckalphie 你们travis挂了

@Garfield550
Copy link
Collaborator

@Chen-jj 接锅,fe6b13c 有 unit test 错误。

@Chen-jj
Copy link
Contributor

Chen-jj commented Nov 5, 2019

CI 错误可以忽略

@archiewx
Copy link
Author

archiewx commented Nov 5, 2019

大佬们,666

@archiewx
Copy link
Author

archiewx commented Nov 9, 2019

@Chen-jj 忽略。关键是你们处理一下pr啊

@Littly Littly self-requested a review November 11, 2019 02:43
Copy link
Contributor

@Littly Littly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献~
tes变量可以删除,但宽度取值不做修改~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-h5 Target - 编译到 H5 V-2 Version - 2.x
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants