Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 添加微信小程序webp属性 #5273

Merged
merged 2 commits into from
Jan 8, 2020
Merged

fix: 添加微信小程序webp属性 #5273

merged 2 commits into from
Jan 8, 2020

Conversation

spencer17x
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@Garfield550 Garfield550 self-requested a review January 8, 2020 16:00
@Garfield550 Garfield550 self-assigned this Jan 8, 2020
Garfield550
Garfield550 approved these changes Jan 8, 2020
View reviewed changes
Copy link
Collaborator

@Garfield550 Garfield550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看起来没问题，感谢 PR。

@Garfield550 Garfield550 merged commit 2dd00dc into NervJS:2.x Jan 8, 2020
Garfield550 pushed a commit that referenced this pull request Jan 8, 2020
@spencer17x @Garfield550
fix(weapp): 添加微信小程序 webp 属性和修复函数式组件缺少的 externalClasses 类型 (#5273)
c82380e 
* fix: 添加微信小程序webp属性

* fix: 修复函数式组件缺少的externalClasses类型
@taro-bot taro-bot bot mentioned this pull request Jan 11, 2020
Closed
jiangzm pushed a commit to jiangzm/taro that referenced this pull request Dec 7, 2020
@spencer17x @jiangzm
fix(weapp): 添加微信小程序 webp 属性和修复函数式组件缺少的 externalClasses 类型 (NervJS#5273)
9ae642d 
* fix: 添加微信小程序webp属性

* fix: 修复函数式组件缺少的externalClasses类型
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield550 Garfield550 Garfield550 approved these changes

Assignees

@Garfield550 Garfield550

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencer17x @Garfield550