Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

补全环境变量文档 #5284

Merged
merged 1 commit into from
Jan 10, 2020
Merged

补全环境变量文档 #5284

merged 1 commit into from
Jan 10, 2020

Conversation

xiaoxintang
Copy link

@xiaoxintang xiaoxintang commented Jan 10, 2020 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)
修改环境变量文档

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

@Garfield550 Garfield550 self-requested a review January 10, 2020 02:42
Garfield550
Garfield550 approved these changes Jan 10, 2020
View reviewed changes
Copy link
Collaborator

@Garfield550 Garfield550 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有什么问题，不过版本化的文档其实不用改

website/versioned_docs/version-1.3.14/apis/about/env.md Show resolved Hide resolved
@Garfield550 Garfield550 merged commit a5f57c8 into NervJS:2.x Jan 10, 2020
@taro-bot taro-bot bot mentioned this pull request Jan 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garfield550 Garfield550 Garfield550 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiaoxintang @Garfield550