fix(runtime): 修复、迭代生命周期 #6996
Merged
fix(runtime): 修复、迭代生命周期 #6996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 生命周期 hooks 在组件销毁时，同时销毁监听回调。 * 修复页面为 Class 组件，子组件使用生命周期 hooks 时不触发回调的问题。
* 增加 onAddToFavorites、onShareTimeline 页面事件 hooks * 【Breaking】使用 onShareAppMessage，useShareAppMessage 时，必须设置页面的 enableShareAppMessage 属性为 true，#6825
This was
linked to
issues
Jul 10, 2020
luckyadam
approved these changes
Jul 13, 2020
cncolder
reviewed
Jul 14, 2020
| } | ||
|
|
||
| // onShareAppMessage 和 onShareTimeline 一样，会影响小程序右上方按钮的选项，因此不能默认注册。 | ||
| if (component.onShareAppMessage || component.enableShareAppMessage) { |
There was a problem hiding this comment.
@Chen-jj 这里不应该是 component.prototype.onShareAppMessage 吗?
There was a problem hiding this comment.
component.onShareAppMessage 是给 Vue 用的，根据 prototype 判断可以加下，那么 Class Component 就不用配置 enable 了。
There was a problem hiding this comment.
记录一下：这样还是不完美，HOC 如 connect 后的页面组件会跪，还是要编译时处理一下以自动兼容大部分情况。
cncolder
reviewed
Jul 15, 2020
| } else { | ||
| inst![lifecycle] = callback | ||
| if (isFunction(inst[lifecycle])) { |
There was a problem hiding this comment.
@Chen-jj 如果上面 common.ts 里修复了, 页面实例就没有默认的 onShareAppMessage 回调了, 在函数式组件里 inst[lifecycle] 永远是 undefined, 我们还是应该用 lifecycle 这个字符串上来判断, 以实现页面第一次初始化时设置 onShareAppMessage/onShareTimeline/onAddToFavorites
There was a problem hiding this comment.
createPageConfig 时 inst 是 undefined，小程序 onLoad 时才会绑定。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
修复
特性
这个 PR 是什么类型? (至少选择一个)
这个 PR 满足以下需求:
这个 PR 涉及以下平台: