feat(mini-runner): 为小程序端新增若干编译配置项 #7253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 同步 H5 端的 sourceMapType 配置 * 新增 debugReact 配置，可配置是否使用 development 版本的 React，默认使用 production 版本 * 新增 minifyXML 配置，可配置是否去除 xml 文件中的空格，默认不去除
|
sourceMapType 和 enableSourceMap 是否可以统一 |
2.x 和 3.x H5 沿用的都是这两个配置分开诶，现在统一起来不兼容会不会不是很好？ |
luckyadam
approved these changes
Aug 21, 2020
| sourceMapType: Joi.string(), | ||
| debugReact: Joi.bool(), | ||
| minifyXML: Joi.object().keys({ | ||
| collapseWhitespace: Joi.bool() |
There was a problem hiding this comment.
minifyXML 下有且只有 collapseWhitespace 这一配置么
# Conflicts: # packages/taro-mini-runner/src/plugins/MiniPlugin.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么?
sourceMapType配置debugReact配置，可配置是否使用 development 版本的 React，默认使用 production 版本minifyXML配置，可配置是否去除 xml 文件中的空格，默认不去除这个 PR 是什么类型?
这个 PR 满足以下需求:
这个 PR 涉及以下平台: