Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(type): Add the missed parameter to useRouter #7679

Merged
merged 3 commits into from
Sep 27, 2020
Merged

fix(type): Add the missed parameter to useRouter #7679

merged 3 commits into from
Sep 27, 2020

Conversation

yuezk
Copy link
Contributor

@yuezk yuezk commented Sep 20, 2020 •
edited
Loading

这个 PR 做了什么? (简要描述所做更改)

在 useRouter 的类型定义加添加缺失的 dynamic 参数。

useRouter 的代码实现中是包含这个参数的，如下：

taro/packages/taro-runtime/src/dsl/hooks.ts

Line 81 in 93c6d6e

export const useRouter = (dynamic = false) => {

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用，不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）

其它需要 Reviewer 或社区知晓的内容：

@yuezk
fix(type): Add the missed parameter to useRouter
c455dc4 
`useRouter` supports pass an optional parameter to indicate whether the the router should be dynamic or not. But it was missed in the type definitions.

See https://github.com/NervJS/taro/blob/93c6d6e18f29ab2c2844da8641746b55d6a7df18/packages/taro-runtime/src/dsl/hooks.ts#L81
@Chen-jj Chen-jj added the V-3 Version - 3.x label Sep 24, 2020
@Chen-jj Chen-jj added the A-typings Area - TypeScript Typings 相关 label Sep 24, 2020
@taro-bot2 taro-bot2 bot mentioned this pull request Sep 26, 2020
Closed
ZakaryCode
ZakaryCode approved these changes Sep 27, 2020
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢贡献

@ZakaryCode ZakaryCode merged commit d27aefc into NervJS:next Sep 27, 2020
@yuezk yuezk deleted the patch-1 branch September 27, 2020 13:53
@taro-bot2 taro-bot2 bot mentioned this pull request Oct 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode approved these changes

Assignees
No one assigned
Labels
A-typings Area - TypeScript Typings 相关 V-3 Version - 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuezk @ZakaryCode @Chen-jj