Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mininum and maximum percentage for graphs in dashboards #1782

Closed
faguayot opened this issue Feb 27, 2023 · 6 comments · Fixed by #1790
Closed

Change mininum and maximum percentage for graphs in dashboards #1782

faguayot opened this issue Feb 27, 2023 · 6 comments · Fixed by #1790
Labels

Comments

@faguayot
Copy link

Describe the bug
Define the minimum and maximum in the percentage graphs since we can't have a right vision of the use of any value due to we are not painting the minimum to 0% and the maxixum which should be 100% in most of cases.

Environment
Provide accurate information about the environment to help us reproduce the issue.

  • Harvest version: harvest version 23.02.0-1 (commit 627311a) (build date 2023-02-21T08:32:43-0500) linux/amd64
  • OS: Red Hat Enterprise Linux release 8.4 (Ootpa)
  • Install method: rhel
  • ONTAP Version: 9.7 and 9.10.1

Expected behavior
image

Actual behavior
image

Additional context
It is recomment to review all dashboards, since I have seen the same situation in differents.

@rahulguptajss
Copy link
Contributor

@Hardikl Could you check this.

@cgrinds cgrinds added bug Something isn't working customer 23.05 and removed status/needs-triage labels Feb 27, 2023
@cgrinds
Copy link
Collaborator

cgrinds commented Feb 27, 2023

Thanks @faguayot!

The advantage of the current behavior is small % differences are more obvious. Extending the range from 0 to 1 "flattens" some values and makes it harder to spot minor changes. Of course, that advantage can also be considered a con. I agree that the defaults should probably be fixed between 0 and 1. We'll investigate and get back to you.

@cgrinds
Copy link
Collaborator

cgrinds commented Feb 27, 2023

Soft min and max may be a way to improve this, although for most of our percent panels a hard min/max will typically work fine too.

Soft min and soft max settings can prevent blips from turning into mountains when the data is mostly flat, and hard min or max derived from standard min and max field options can prevent intermittent spikes from flattening useful detail by clipping the spikes past a specific point.

Example

@faguayot
Copy link
Author

@cgrinds Thanks for you quick answer. I understand what you say about small % differences, and it makes sense. I guess depending on the situation could help use the minimum 0 and maximum 100 (or 1 depending on the scale) or not. When I look for something

  • First I look for a long period of time and check if there is any varition of the curve even mininum.
  • Second I zoom in the specific time where I've found that variation to check if there is an important change or not.

@cgrinds
Copy link
Collaborator

cgrinds commented Mar 2, 2023

hi @faguayot if you want to try these out before the next release, you can grab the latest nightly build.

@cgrinds
Copy link
Collaborator

cgrinds commented May 1, 2023

Verified on 3ffa2eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants