feat: collection of other counters for fcvi perf object #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Iwarp counters are available in openlab cluster and fcvi counters are in mcc cluster in bigtop. |
|
3 duplicate panels of fcvi are removed from Highlight and added remaining in FCVI drilldown only. |
Openlab and Bigtop setups are created for testing of Iwarp and Fcvi counters. |
rahulguptajss
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neither ZapiPerf object
fcvinor RestPerf apiapi/cluster/counter/tables/fcviwould be having the detail of port, which customer has asked for.So, To add those port details, one extra call has been made in plugin. Calling
metrocluster-interconnect-adapter-get-iterin Zapiperf plugin and callingapi/private/cli/metrocluster/interconnect/adapterin RestPerf plugin with desired attrs.Tested against Bigtop MCC cluster.
