feat: improve Rest Collector #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgrinds
reviewed
Mar 14, 2024
cmd/tools/rest/href_builder.go
Outdated
| @@ -81,6 +88,9 @@ func (b *HrefBuilder) Build() string { | |||
| if b.returnTimeout != nil { | |||
| addArg(&href, "&return_timeout=", strconv.Itoa(*b.returnTimeout)) | |||
| } | |||
| if b.isIgnoreUnknownFieldsEnabled && util.IsPublicAPI(b.apiPath) { | |||
There was a problem hiding this comment.
ignore_unknown_fields=true works for private CLI. Is there a good reason to disallow its use? Allowing it would make our templates a bit more version resilient
There was a problem hiding this comment.
Ok, I have added it for private CLI as well.
We decided not to add this, as it didn't make sense based on one of the discussions, which is also documented here.
#2164 (comment)
|
Before: After.log Difference Percentage Change Alloc: Alloc improvements are in range of ~6-8% |
|
This PR reduces bytesRx by ~27% when monitoring the |
cgrinds
previously approved these changes
Mar 15, 2024
Hardikl
approved these changes
Mar 18, 2024
Comment on lines
+391
to
+394
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
There was a problem hiding this comment.
this is not needed as err just hasn't been used.
| @@ -677,7 +677,7 @@ func (r *RestPerf) PollData() (map[string]*matrix.Matrix, error) { | |||
|
|
|||
| href := rest.NewHrefBuilder(). | |||
| APIPath(dataQuery). | |||
| Fields(r.Prop.Fields). | |||
| Fields([]string{"*"}). | |||
There was a problem hiding this comment.
for restperf, we will always send *?
There was a problem hiding this comment.
Yes. It will change as part of next story.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.