Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supporting Consistency Group drilldowns in snapmirror dashboard #2830

Merged
merged 16 commits into from
May 13, 2024

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Apr 12, 2024

No description provided.

@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 12, 2024

As clusters are in bigtop, creating the system there and update for review.

@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 16, 2024

PR Changes includes these:

  • Added variable for consistency group
  • Added panel of Consistency Group in Highlights which shows count of cg and can be filtered by CG var
  • Added Consistency Group Data Protection Analysis per Cluster panels which can be filtered by CG var.

@@ -345,7 +345,7 @@
{
"cacheTimeout": null,
"datasource": "${DS_PROMETHEUS}",
"description": "Number of insync snapmirrors.",
"description": "Number of consistency group protected snapmirrors.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is not part of this PR, but it's something that could be improved if possible in seperate PR.

Given that SnapMirror is not node-driven, could we also consider removing destinationNode and sourceNode dropdowns. They are used as filter in 'SnapMirror per Node' section? This change might reduce the number of dropdowns in the dashboard and simplify the dashboard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, We can discuss this in meeting.

grafana/dashboards/cmode/snapmirror.json Show resolved Hide resolved
@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 17, 2024

Merged 2 tables for snapmirror
image

Merged 2 tables for CG
image

pending item:

  • filtering in highlights table based on CG var

@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 17, 2024

Supporting Top $TopResources Last Transfers by Transfer Data Size table filter with CG var,

image

Just to note,
There are 3 queries in table and below graphs, snapmirror_last_transfer_duration, snapmirror_last_transfer_size and snapmirror_lag_time. If any point in time the metrics won't be available for that relationship(there may be many reason as no lag or no successful transfer or unhealthy relationhsip, etc..), then it won't be visible in the table/graph.

@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 17, 2024

After hide the node vars, validated that all the panels were populated as expected after hiding them.

image

@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 23, 2024

Added sourceConsistencyGroup and DestinationConsistencyGroup variables.

image

@Hardikl
Copy link
Contributor Author

Hardikl commented Apr 24, 2024

Updated the UI panels to accommodate the flexgroup panel count.

image

Added decent documentation of all kind of relationships.

image

rahulguptajss
rahulguptajss previously approved these changes May 8, 2024
@cgrinds
Copy link
Collaborator

cgrinds commented May 13, 2024

Looks good @Hardikl. @Nikhita-13 has also checked and verified these changes.

cgrinds
cgrinds previously approved these changes May 13, 2024
@Hardikl Hardikl dismissed stale reviews from cgrinds and rahulguptajss via 1a3dd68 May 13, 2024 14:40
@cgrinds cgrinds merged commit 284fded into main May 13, 2024
6 checks passed
@cgrinds cgrinds deleted the hl_cg_panels branch May 13, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancing SnapMirror Dashboard to include Consistency Group drilldowns.
3 participants