-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supporting Consistency Group drilldowns in snapmirror dashboard #2830
Conversation
As clusters are in bigtop, creating the system there and update for review. |
PR Changes includes these:
|
@@ -345,7 +345,7 @@ | |||
{ | |||
"cacheTimeout": null, | |||
"datasource": "${DS_PROMETHEUS}", | |||
"description": "Number of insync snapmirrors.", | |||
"description": "Number of consistency group protected snapmirrors.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is not part of this PR, but it's something that could be improved if possible in seperate PR.
Given that SnapMirror is not node-driven, could we also consider removing destinationNode
and sourceNode
dropdowns. They are used as filter in 'SnapMirror per Node' section? This change might reduce the number of dropdowns in the dashboard and simplify the dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, We can discuss this in meeting.
Looks good @Hardikl. @Nikhita-13 has also checked and verified these changes. |
No description provided.