Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handled flexgroup based on volume config call #3199

Merged
merged 4 commits into from
Oct 9, 2024
Merged

fix: handled flexgroup based on volume config call #3199

merged 4 commits into from
Oct 9, 2024

Conversation

Hardikl
Copy link
Contributor

@Hardikl Hardikl commented Oct 7, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Oct 7, 2024
@Hardikl
Copy link
Contributor Author

Hardikl commented Oct 7, 2024

Validated with customer data,
before changes,
image

With these changes, All the volume perf metrics along with volume_aggr_labels would be populated as expected.

cgrinds
cgrinds reviewed Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@cgrinds cgrinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of fetching the volumes everytime the performance plugin runs, we should request it at some plugin invocation rate similar to other plugins to reduce the load.

cmd/collectors/restperf/plugins/volume/volume.go Show resolved Hide resolved
cmd/collectors/volume.go Show resolved Hide resolved
@Hardikl
Copy link
Contributor Author

Hardikl commented Oct 8, 2024

Instead of fetching the volumes everytime the performance plugin runs, we should request it at some plugin invocation rate similar to other plugins to reduce the load.

made invocation same as other plugins.

@Hardikl Hardikl linked an issue Oct 8, 2024 that may be closed by this pull request
volume perf plugin failed when flexvol naming has __000x #3201
Closed
@cgrinds cgrinds merged commit 391b6b7 into main Oct 9, 2024
6 checks passed
@cgrinds cgrinds deleted the hl_t branch October 9, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgrinds cgrinds cgrinds left review comments

@rahulguptajss rahulguptajss rahulguptajss approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

volume perf plugin failed when flexvol naming has __000x
3 participants
@Hardikl @cgrinds @rahulguptajss