140 new resource securityroles 1 #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenjun666
requested review from
carchi8py,
chuyich and
suhasbshekar
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if deleteDefaultPrivileges { | ||
| err = interfaces.DeleteSecurityRolePrivileges(errorHandler, *client, privilege.Path, data.Name.ValueString(), restInfo.Owner.Id) | ||
| if err != nil { | ||
| errorHandler.MakeAndReportError("error deleting default security_role privileges", "error on DELETE API created default privileges: {path: 'DEFAULT', access: 'none', query: ''}") |
Check warning
Code scanning / gosec
Errors unhandled.
| log.Printf("going to create privilege : %v", planPrivilege) | ||
| err = interfaces.CreateSecurityRolePrivileges(errorHandler, *client, planPrivilege, plan.Name.ValueString(), svm.UUID) | ||
| if err != nil { | ||
| errorHandler.MakeAndReportError("error deleting default security_role privileges", fmt.Sprint("error on DELETE API created default privileges: {path: 'DEFAULT', access: 'none', query: ''} :", err)) |
Check warning
Code scanning / gosec
Errors unhandled.
carchi8py
approved these changes
Aug 28, 2024
chuyich
requested changes
Aug 29, 2024
suhasbshekar
requested changes
Aug 30, 2024
chuyich
requested changes
Sep 6, 2024
suhasbshekar
approved these changes
Sep 10, 2024
chuyich
reviewed
Sep 11, 2024
I don't think it matters, as query is privilege.query, if API returns nothing of query, the struct will omit empty. |
chuyich
approved these changes
Sep 13, 2024
…m-provider-netapp-ontap into 140-new-resource-securityroles-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.