Bug Fix. Increased timeout to 5 minutes #940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwin-kok
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operator creates a POD "transient-trident-version-pod" and executes a command ("/bin/tridentctl version --client -o yaml") inside it. In "ExecPodForVersionInformation" in k8s_client.go it tries to execute this command several times, with a backoff mechanism. However, the hard limit is 30s. The version extract command must be executed within 30s, otherwise the operator will delete the POD again.
We have a slow setup where it takes longer to startup a POD. Unfortunately longer than 30s. The result is that the operator kills the POD (which is still starting up) and retries again to run a new POD. This happens indefinitely until the version info could be extracted within 30s.
The proposal is to increase this timeout to 5 minutes (this PR). Such that slower environments have more time to spin up PODs. Note that as soon as the version info is extracted, the operator continues. i.e. fast environments are not affected by this timeout increase.