Skip to content

Commit

Permalink
sysutils/dua-cli: update to 2.17.1
Browse files Browse the repository at this point in the history
Improvements to aggregate progress reporting

Previously, aggregate mode progress reports were handled by an
infinitely-looping thread carrying a 64-bit atomic of the current count,
which it would print periodically.

This resulted in #99 - breaking on platforms without 64-bit atomics,
for which a feature was added to disable it.

It also implied a race condition, where the "Enumerating ..." message
could be printed after results had been gathered but before dua exited.

Additionally, part of the status message could be left on the display if
the first line of a report was too short to cover it.

This commit should resolve these:

    The 64-bit atomic counter is replaced with an 8-bit AtomicBool
    All printing is controlled from the main thread
    The first line is cleared prior to printing a report

The only notable drawback I see with this approach is that progress
reporting can sometimes be delayed, since the display is only evaluated
for update during periods the aggregation loop makes progress. The
practical difference appears relatively minor.

Since this should resolve #99, the aggregate-scan-progress feature is
removed.

Special thanks to @Freaky for the contribution!
BREAKING change for package maintainers

The aggregate-scan-progress feature was removed as it shouldn't be required
anymore.
  • Loading branch information
0323pin committed Mar 20, 2022
1 parent 339c1f3 commit 0320448
Show file tree
Hide file tree
Showing 3 changed files with 147 additions and 147 deletions.
4 changes: 2 additions & 2 deletions sysutils/dua-cli/Makefile
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# $NetBSD: Makefile,v 1.8 2022/01/22 16:11:48 pin Exp $
# $NetBSD: Makefile,v 1.9 2022/03/20 16:24:01 pin Exp $

DISTNAME= dua-cli-2.17.0
DISTNAME= dua-cli-2.17.1
CATEGORIES= sysutils
MASTER_SITES= ${MASTER_SITE_GITHUB:=Byron/}
GITHUB_TAG= v${PKGVERSION_NOREV}
Expand Down
72 changes: 36 additions & 36 deletions sysutils/dua-cli/cargo-depends.mk
Original file line number Diff line number Diff line change
@@ -1,102 +1,102 @@
# $NetBSD: cargo-depends.mk,v 1.4 2021/12/29 05:46:13 pin Exp $
# $NetBSD: cargo-depends.mk,v 1.5 2022/03/20 16:24:01 pin Exp $

CARGO_CRATE_DEPENDS+= ansi_term-0.12.1
CARGO_CRATE_DEPENDS+= anyhow-1.0.52
CARGO_CRATE_DEPENDS+= anyhow-1.0.56
CARGO_CRATE_DEPENDS+= atty-0.2.14
CARGO_CRATE_DEPENDS+= autocfg-1.0.1
CARGO_CRATE_DEPENDS+= autocfg-1.1.0
CARGO_CRATE_DEPENDS+= bitflags-1.3.2
CARGO_CRATE_DEPENDS+= byte-unit-4.0.13
CARGO_CRATE_DEPENDS+= byte-unit-4.0.14
CARGO_CRATE_DEPENDS+= cassowary-0.3.0
CARGO_CRATE_DEPENDS+= cfg-if-1.0.0
CARGO_CRATE_DEPENDS+= chrono-0.4.19
CARGO_CRATE_DEPENDS+= clap-3.0.0-rc.8
CARGO_CRATE_DEPENDS+= clap_derive-3.0.0-rc.8
CARGO_CRATE_DEPENDS+= clap-3.1.6
CARGO_CRATE_DEPENDS+= clap_derive-3.1.4
CARGO_CRATE_DEPENDS+= colored-2.0.0
CARGO_CRATE_DEPENDS+= const-sha1-0.2.0
CARGO_CRATE_DEPENDS+= core-foundation-sys-0.8.3
CARGO_CRATE_DEPENDS+= crossbeam-0.8.1
CARGO_CRATE_DEPENDS+= crossbeam-channel-0.5.1
CARGO_CRATE_DEPENDS+= crossbeam-channel-0.5.2
CARGO_CRATE_DEPENDS+= crossbeam-deque-0.8.1
CARGO_CRATE_DEPENDS+= crossbeam-epoch-0.9.5
CARGO_CRATE_DEPENDS+= crossbeam-queue-0.3.2
CARGO_CRATE_DEPENDS+= crossbeam-utils-0.8.5
CARGO_CRATE_DEPENDS+= crossterm-0.20.0
CARGO_CRATE_DEPENDS+= crossterm_winapi-0.8.0
CARGO_CRATE_DEPENDS+= crosstermion-0.8.1
CARGO_CRATE_DEPENDS+= crossbeam-epoch-0.9.7
CARGO_CRATE_DEPENDS+= crossbeam-queue-0.3.4
CARGO_CRATE_DEPENDS+= crossbeam-utils-0.8.7
CARGO_CRATE_DEPENDS+= crossterm-0.22.1
CARGO_CRATE_DEPENDS+= crossterm_winapi-0.9.0
CARGO_CRATE_DEPENDS+= crosstermion-0.9.0
CARGO_CRATE_DEPENDS+= ctor-0.1.21
CARGO_CRATE_DEPENDS+= diff-0.1.12
CARGO_CRATE_DEPENDS+= either-1.6.1
CARGO_CRATE_DEPENDS+= filesize-0.2.0
CARGO_CRATE_DEPENDS+= fixedbitset-0.4.0
CARGO_CRATE_DEPENDS+= fixedbitset-0.4.1
CARGO_CRATE_DEPENDS+= form_urlencoded-1.0.1
CARGO_CRATE_DEPENDS+= glob-0.3.0
CARGO_CRATE_DEPENDS+= hashbrown-0.11.2
CARGO_CRATE_DEPENDS+= heck-0.3.3
CARGO_CRATE_DEPENDS+= heck-0.4.0
CARGO_CRATE_DEPENDS+= hermit-abi-0.1.19
CARGO_CRATE_DEPENDS+= idna-0.2.3
CARGO_CRATE_DEPENDS+= indexmap-1.7.0
CARGO_CRATE_DEPENDS+= indexmap-1.8.0
CARGO_CRATE_DEPENDS+= instant-0.1.12
CARGO_CRATE_DEPENDS+= itertools-0.10.3
CARGO_CRATE_DEPENDS+= jwalk-0.6.0
CARGO_CRATE_DEPENDS+= lazy_static-1.4.0
CARGO_CRATE_DEPENDS+= libc-0.2.112
CARGO_CRATE_DEPENDS+= lock_api-0.4.5
CARGO_CRATE_DEPENDS+= libc-0.2.120
CARGO_CRATE_DEPENDS+= lock_api-0.4.6
CARGO_CRATE_DEPENDS+= log-0.4.14
CARGO_CRATE_DEPENDS+= malloc_buf-0.0.6
CARGO_CRATE_DEPENDS+= matches-0.1.9
CARGO_CRATE_DEPENDS+= memchr-2.4.1
CARGO_CRATE_DEPENDS+= memoffset-0.6.5
CARGO_CRATE_DEPENDS+= mio-0.7.14
CARGO_CRATE_DEPENDS+= miow-0.3.7
CARGO_CRATE_DEPENDS+= ntapi-0.3.6
CARGO_CRATE_DEPENDS+= ntapi-0.3.7
CARGO_CRATE_DEPENDS+= num-integer-0.1.44
CARGO_CRATE_DEPENDS+= num-traits-0.2.14
CARGO_CRATE_DEPENDS+= num_cpus-1.13.1
CARGO_CRATE_DEPENDS+= numtoa-0.1.0
CARGO_CRATE_DEPENDS+= objc-0.2.7
CARGO_CRATE_DEPENDS+= once_cell-1.9.0
CARGO_CRATE_DEPENDS+= open-2.0.2
CARGO_CRATE_DEPENDS+= once_cell-1.10.0
CARGO_CRATE_DEPENDS+= open-2.1.1
CARGO_CRATE_DEPENDS+= os_str_bytes-6.0.0
CARGO_CRATE_DEPENDS+= output_vt100-0.1.2
CARGO_CRATE_DEPENDS+= output_vt100-0.1.3
CARGO_CRATE_DEPENDS+= parking_lot-0.11.2
CARGO_CRATE_DEPENDS+= parking_lot_core-0.8.5
CARGO_CRATE_DEPENDS+= pathdiff-0.2.1
CARGO_CRATE_DEPENDS+= percent-encoding-2.1.0
CARGO_CRATE_DEPENDS+= petgraph-0.6.0
CARGO_CRATE_DEPENDS+= pretty_assertions-1.0.0
CARGO_CRATE_DEPENDS+= pretty_assertions-1.2.0
CARGO_CRATE_DEPENDS+= proc-macro-error-1.0.4
CARGO_CRATE_DEPENDS+= proc-macro-error-attr-1.0.4
CARGO_CRATE_DEPENDS+= proc-macro2-1.0.35
CARGO_CRATE_DEPENDS+= quote-1.0.10
CARGO_CRATE_DEPENDS+= proc-macro2-1.0.36
CARGO_CRATE_DEPENDS+= quote-1.0.15
CARGO_CRATE_DEPENDS+= rayon-1.5.1
CARGO_CRATE_DEPENDS+= rayon-core-1.9.1
CARGO_CRATE_DEPENDS+= redox_syscall-0.2.10
CARGO_CRATE_DEPENDS+= redox_syscall-0.2.11
CARGO_CRATE_DEPENDS+= redox_termios-0.1.2
CARGO_CRATE_DEPENDS+= scopeguard-1.1.0
CARGO_CRATE_DEPENDS+= signal-hook-0.3.13
CARGO_CRATE_DEPENDS+= signal-hook-mio-0.2.1
CARGO_CRATE_DEPENDS+= signal-hook-registry-1.4.0
CARGO_CRATE_DEPENDS+= smallvec-1.7.0
CARGO_CRATE_DEPENDS+= smallvec-1.8.0
CARGO_CRATE_DEPENDS+= strsim-0.10.0
CARGO_CRATE_DEPENDS+= syn-1.0.84
CARGO_CRATE_DEPENDS+= sysinfo-0.22.3
CARGO_CRATE_DEPENDS+= termcolor-1.1.2
CARGO_CRATE_DEPENDS+= syn-1.0.88
CARGO_CRATE_DEPENDS+= sysinfo-0.23.5
CARGO_CRATE_DEPENDS+= termcolor-1.1.3
CARGO_CRATE_DEPENDS+= termion-1.5.6
CARGO_CRATE_DEPENDS+= textwrap-0.14.2
CARGO_CRATE_DEPENDS+= textwrap-0.15.0
CARGO_CRATE_DEPENDS+= time-0.1.44
CARGO_CRATE_DEPENDS+= tinyvec-1.5.1
CARGO_CRATE_DEPENDS+= tinyvec_macros-0.1.0
CARGO_CRATE_DEPENDS+= trash-2.0.3
CARGO_CRATE_DEPENDS+= tui-0.16.0
CARGO_CRATE_DEPENDS+= tui-react-0.16.0
CARGO_CRATE_DEPENDS+= trash-2.0.4
CARGO_CRATE_DEPENDS+= tui-0.17.0
CARGO_CRATE_DEPENDS+= tui-react-0.17.0
CARGO_CRATE_DEPENDS+= unicode-bidi-0.3.7
CARGO_CRATE_DEPENDS+= unicode-normalization-0.1.19
CARGO_CRATE_DEPENDS+= unicode-segmentation-1.8.0
CARGO_CRATE_DEPENDS+= unicode-segmentation-1.9.0
CARGO_CRATE_DEPENDS+= unicode-width-0.1.9
CARGO_CRATE_DEPENDS+= unicode-xid-0.2.2
CARGO_CRATE_DEPENDS+= url-2.2.2
CARGO_CRATE_DEPENDS+= utf8-width-0.1.5
CARGO_CRATE_DEPENDS+= version_check-0.9.3
CARGO_CRATE_DEPENDS+= version_check-0.9.4
CARGO_CRATE_DEPENDS+= wasi-0.10.0+wasi-snapshot-preview1
CARGO_CRATE_DEPENDS+= wild-2.0.4
CARGO_CRATE_DEPENDS+= winapi-0.3.9
Expand Down
Loading

0 comments on commit 0320448

Please sign in to comment.