Initial AppleTalk fixes #1339
Initial AppleTalk fixes #1339
Conversation
|
@NJRoadfan Thank you for working on this. A minor housekeeping note: For PRs that target the main branch, let's not add the version number tag like [4.0]. They are only for distinguishing PRs against stable branches. Let's keep the tag soup manageable. ;) I updated https://github.com/Netatalk/netatalk/wiki/Developer-Notes#pull-requests to make note of this. |
|
I've got a2boot and timelord compiling. Right now working on getting atalkd and papd working. After that, all that is left is getting afpd back to supporting ASP transports. |
|
If anyone wants to test, you need to disable ASP from libatalk for now in order to compile with AppleTalk turned on. In |
etc/papd/uam.c
Outdated
| @@ -60,8 +60,10 @@ struct uam_mod *uam_load(const char *path, const char *name) | |||
|
|
|||
| /* version check would go here */ | |||
|
|
|||
| /* Temporary hack below to get this to compile with 3.x, we really should be passing an AFPObj as the first parameter */ | |||
There was a problem hiding this comment.
Please prefix this with a TODO: so that it's easy to find later.
| if have_appletalk | ||
| subdir('atalkd') | ||
| subdir('papd') | ||
| endif |
There was a problem hiding this comment.
Nitpick: Let's add a final newline for consistency. :)
|
@NJRoadfan Looks good overall. I left a few minor comments. Can you please rebase this branch now so that it's a single commit, or a series of commits with atomic changes that compile independently? (reminder: |
Many changes to integrate several of the old AppleTalk daemons and utilities into the 3.x codebase. Most of it was dealing with changes to libatalk's unicode conversion interface. The following now compile and run: -atalkd service (tested working) -papd service (tested working) -timelord service (runs, but not tested further) -a2boot service (runs, but not tested further) -nbplkup (tested working) -nbprgstr (tested working) -nbpunrgstr (tested working) -getzones (tested working) Note that as of now, atalkd, papd, and getzones are hardcoded to use the MAC_ROMAN character encoding. This was already the case on FreeBSD and platforms using systemd as they had no way to set and use the systemwide character sets anyway.
|
Nothing further here. |
-Add pre-AFP 2.2 login strings.
-Add back GS/OS date preservation fix.
-Get the classic AppleTalk daemons working.
-Get the classic AppleTalk commandline tools working.
Fixes part of #1333