Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce AppleTalk related manual pages #1351

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

rdmark
Copy link
Member

@rdmark rdmark commented Jul 30, 2024

Brings back and updates the metadata for all AppleTalk related man pages, including building them for the html manual.

One change from 2.x, is that the man page aliases are achieved through straight up symlinking, rather than the static "link" man pages under man/man* ... since we did away with the intermediate step. The drawback is that you cannot install 4.x on top of 2.x, since a symlink cannot overwrite a file. Not sure if there's a better solution for this.

I think this is acceptable, since the 2.x->4.x migration path involves manual steps anyways (compare the 2.x->3.x migration path) so adding one for deleting these fake man pages shouldn't be too bad...

OTOH, maybe we can just ditch those man page aliases for simplicity.

@rdmark rdmark linked an issue Jul 30, 2024 that may be closed by this pull request
@rdmark
Copy link
Member Author

rdmark commented Jul 30, 2024

For the record, the part that generates the symlinks is

nbp_symlinks = [
    'nbplkup.1',
    'nbprgstr.1',
    'nbpunrgstr.1',
]

foreach symlink : nbp_symlinks
    install_symlink(symlink, install_dir: mandir / 'man1', pointing_to: 'nbp.1')
endforeach

@rdmark rdmark force-pushed the 1350-restore-appletalk-manual-pages branch from 8bbd890 to 3406574 Compare July 30, 2024 12:51
Copy link

sonarcloud bot commented Jul 30, 2024

@rdmark
Copy link
Member Author

rdmark commented Jul 30, 2024

I decided to revert the symlinking of the three nbp* man page aliases. The added complexity and friction to the migration path isn't worth the tiny benefit.

@rdmark rdmark merged commit 0889cac into main Jul 30, 2024
15 checks passed
@rdmark rdmark deleted the 1350-restore-appletalk-manual-pages branch July 30, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore AppleTalk manual pages
1 participant