-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ASP services to work with 3.x codebase. #1355
Conversation
This might be a good time to turn on -Dwith-appletalk=true for the GitHub CI workflow jobs to start continuously testing the code. Do you want to make that change in this PR? |
Added -Dwith-appletalk=true to CI actions. Several platforms are failing with weird errors. Alpine is failing on values that are coming from built in libraries. |
Alpine and OmniOS are failing in a similar way with missing All of the BSDs are failing in papd with a missing Off the top of my head: probably due to some missing platform or capability macro. BTW, OpenBSD is passing just because there's a hard coded |
Looks like there are a few obsolete platform macros remaining in the 2.x code base causing the failures. The two in question are |
122f807
to
0da547f
Compare
@NJRoadfan This looks good to me now. I think it would be cleaner to rebase this changeset into a single commit. |
There were some changes to `server_child.h` in the 3.x codebase. This updates the ASP routines to work with the newer code. Please note that this is untested until AppleTalk support is re-added into afpd. Misc. fixes to allow building on multiple platforms Remove some obsolete platform macros. With this PR, one can now enable AppleTalk and build main successfully.
0da547f
to
2dc7486
Compare
There were some changes to
server_child.h
in the 3.x codebase. This updates the ASP routines to work with the newer code. Please note that this is untested until AppleTalk support is re-added into afpd.With this PR, one can now enable AppleTalk and build main successfully.