meson: Detect native Avahi before mDNS #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@singular0 Thank you for the PR! I understand the nature of the fix. Empirically, this makes the builds on Arch / Alpine / NetBSD / OmniOS use native Avahi instead of mDNS compatibility. Only macOS and Solaris uses native mDNS. I have one request: Can you please amend the commit message to be a little bit more descriptive? These commit messages are very valuable when generating changelogs or traversing the commit log in the future. See the project guidelines here: https://github.com/Netatalk/netatalk/wiki/Developer-Notes#commit-messages In your case, something like "meson: Detect native Avahi before mDNS" If you need a refresher, the git commands would look like: |
singular0
changed the title
|
@rdmark Updated commit as requested |
rdmark
approved these changes
Oct 5, 2024
|
Merged. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Avahi includes
dns_sd.h, currently build will always detect mDNS as Zeroconf provider. Patch changes the logic to first detect and use Avahi and if not found fallback to mDNS.