Bring back custom icon option for Classic Mac OS #1626
Conversation
rdmark
force-pushed
the
1622-bring-back-global-icon-option
branch
from
37f25d1
to
d58751d
Compare
rdmark
changed the title
rdmark
force-pushed
the
1622-bring-back-global-icon-option
branch
from
d58751d
to
caaf6e5
Compare
- In afp.conf, added string option `legacy icon' to set the style - Available options are deamon, declogo, globe, hagar, sublogo - This also reintroduces the DSI / DDP transport layer volume icons
rdmark
force-pushed
the
1622-bring-back-global-icon-option
branch
from
caaf6e5
to
a75b0c2
Compare
|
|
@NJRoadfan When you have the opportunity, may I ask you to test the AppleTalk transport layer icon? I don't have any AppleTalk systems handy at the moment (in the middle of being shipped across the world.) |
|
It does work. Note that if AppleTalk is enabled, it always overrides the ASIP icon with the classic AppleTalk style no matter how you connect. |
|
@NJRoadfan Thanks for testing. Good to know that nothing is broken, although it was not exactly what I wanted to achieve. Will make another attempt in the future when I have AppleTalk machines again to test with. |
|
No need for an actual machine. You can test it with |
|
asip-status only makes TCP requests though, doesn't it? So I cannot test the DDP-only scenario this way. |
|
The FPGetSrvrInfo packet is the same for both transports. That might need to change in the future though as some older clients are choking if a FPGetSrvrInfo packet exceeds 512 bytes. This is mostly because of the added AFP versions and UAMs reported by Netatalk. |
In addition to the ability to customize the icon, we bring back the logic that gives you a different default icon depending on whether the DSI or DDP transport layer is used.
String option `legacy icon' allows you to enable the custom icon by setting it to one of the below strings. Default value is a blank string, which will fall back to either the DSI or DDP icon.
The icon styles are brought back from the 2.x era icon.h. In the past the icon style was auto detected depending on your host OS, but now you are able to pick and choose. Available icon styles are: