docker: Containerized testsuite and build containers in CI workflow #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdmark
force-pushed
the
1649-create-testsuite-docker-image
branch
2 times, most recently
from
297b5b0
to
5bc7b38
Compare
rdmark
changed the title
rdmark
force-pushed
the
1649-create-testsuite-docker-image
branch
from
5bc7b38
to
bec8faf
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a Docker container that builds both netatalk and the testsuite. While the baseline spectest test suite can be run remotely, the tier 2 spectest requires access to the local filesystem, so I opted to have the netatalk instance under test in the same container as the testsuite. AFP requests still done over port 548 but on a local socket.
Additionally, create a new GitHub actions workflow that builds the Docker containers, publishes them to the GitHub container store, and then runs the two containerized spectest suites.