Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson: Fix PAM config directory detection #1681

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

singular0
Copy link
Contributor

@singular0 singular0 commented Oct 24, 2024

In case -Dwith-pam-config-path was not explicitly specified, even if actual pam.d directory was located on the system, {prefix}/etc/pam.d was used instead to install netatalk.pamd

@rdmark
Copy link
Member

rdmark commented Oct 24, 2024

@singular0 Would you mind writing a sentence or two in the initial comment with a summary of what you changed, and why? This is because the release notes changelog will have a link to this PR, and people clicking through to see the details of the change deserve a brief summary...

@rdmark
Copy link
Member

rdmark commented Oct 24, 2024

Inspecting the CI job logs, Solaris and OmniOS now get empty PAM paths by default. This should be the correct behavior on Solaris-likes since they historically rely on manually updating /etc/pam.conf after installing Netatalk... unless these distros changed recently.

All the other OSes are now detecting the PAM dir as /etc/pam.d which is probably correct across the board.

@rdmark rdmark merged commit 5120192 into Netatalk:main Oct 24, 2024
14 checks passed
@singular0 singular0 deleted the pamd branch November 1, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants