Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix loss of FinderInfo on resource fork creation with AppleDo… #1704

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

NJRoadfan
Copy link
Contributor

…uble EA backend."

If a resource fork is written after FinderInfo, we could lose the Filetype/Creator data for the file.

…uble EA backend."

If a resource fork is written after FinderInfo, we could lose the Filetype/Creator data for the file.
@NJRoadfan
Copy link
Contributor Author

@rdmark See if this passes the spec tests. The ad_init() function nulls out new AppleDouble data structures, so the removal of this code should not cause a problem.

Copy link
Member

@rdmark rdmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only project members and outside collaborators have the privileges to run the Containers jobs... so the AFP test jobs will probably run once I merge to main...

@NJRoadfan NJRoadfan marked this pull request as ready for review October 27, 2024 17:37
@rdmark rdmark merged commit fd12faf into Netatalk:main Oct 27, 2024
24 checks passed
@NJRoadfan
Copy link
Contributor Author

Looks like we're passing now.

@rdmark
Copy link
Member

rdmark commented Oct 27, 2024

Indeed. Are you happy with the assumptions of the tests? We can certainly modify the tests if you disagree with them.

@NJRoadfan NJRoadfan deleted the njroadfan-finderinfo-ea-fix-2 branch October 27, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants