-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MANOPD-68698] Fix check_iaas procedure when cluster is not installed #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theboringstuff
approved these changes
Apr 5, 2022
ilia1243
changed the title
[MANOPD-68698] Fix check_iaas procedure when cluster is not installed
WIP [MANOPD-68698] Fix check_iaas procedure when cluster is not installed
Apr 6, 2022
ilia1243
changed the title
WIP [MANOPD-68698] Fix check_iaas procedure when cluster is not installed
[MANOPD-68698] Fix check_iaas procedure when cluster is not installed
Apr 6, 2022
theboringstuff
approved these changes
Apr 7, 2022
* Simple custom tcp listener written in python 2 is used instead of socat. * If firewalld service is enabled in any node, temporarily stop the service. The fact that it should be disabled, is checked by check_paas procedure by services.security.firewalld.status task.
Exclude balancer nodes from check subnet connectivity.
Added autodetection of preinstalled python executable.
ilia1243
force-pushed
the
bugfix/check_iaas_not_installed
branch
from
April 19, 2022 13:46
78a4da3
to
e0af982
Compare
1. Added gentle alias creating for subnets on installed cluster. 2. Fixed bugs in RemoteExecutor related to exception handling and merging results.
1. Added gentle tcp listener installation and checking for already listening ports.
andrewluckyguy
approved these changes
May 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested by QA for Centos and Ubuntu:
- on clean VMs
- on deployed cluster
koryaga
approved these changes
Jun 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solution
socat
utility might be not installed before cluster installation. Simple custom tcp listener that can be run on python 2 or 3 is used instead ofsocat
.Test Cases
TestCase 1
Test Configuration:
socat
package on nodes, or with enabled firewalld service.Steps:
Results:
TestCase 2
Test Configuration:
Steps:
Results:
Checklist
Reviewers
@koryaga @iLeonidze @Zaborin @alexarefev @Yaroslav-Lahtachev @dmyar21