Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PDSDNREQ-5899] Configure registry credentials #184

Merged
merged 8 commits into from
Jul 7, 2022
Merged

[PDSDNREQ-5899] Configure registry credentials #184

merged 8 commits into from
Jul 7, 2022

Conversation

alexarefev
Copy link
Collaborator

@alexarefev alexarefev commented Jun 23, 2022 •
edited
Loading

Description

[PDSDNREQ-5899]

  • Documentation should describe configuration registry credentials in the containerdConfig section
  • Podman should have ability to work with credentials in containerd configuration

Solution

  • Doc update
  • Add auth.json creation. auth.json is a file that stores authentication credentials for podman
  • Support authentication for podman in etcdctl.sh

How to apply

Not applicable

TestCase 1
Check if credentials work for both containerd and podman

Test Configuration:

  • Hardware: 4CPU/8GB
  • OS: Ubuntu 20.04
  • Inventory: miniHA

Steps:

  1. Run cluster installation
  2. Run check_paas
  3. Run backup procedure

Results:

Before After
Success Success
Success Success
Success Success

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

@alexarefev alexarefev added the documentation Improvements or additions to documentation label Jun 23, 2022
@koryaga koryaga changed the title Configure registry credentials [PDSDNREQ-5899] Configure registry credentials Jun 23, 2022
shmo1218
shmo1218 approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@shmo1218 shmo1218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc changes are reviewed.

@koryaga koryaga marked this pull request as draft June 28, 2022 08:10
@alexarefev alexarefev added improvement New feature or request labels Jun 29, 2022
@alexarefev alexarefev marked this pull request as ready for review June 30, 2022 08:40
@koryaga koryaga merged commit dbdfc6e into main Jul 7, 2022
@koryaga koryaga deleted the registry_credentials branch July 7, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theboringstuff theboringstuff theboringstuff approved these changes

@koryaga koryaga koryaga approved these changes

@alku89 alku89 alku89 approved these changes

@OleksandrIaresko OleksandrIaresko Awaiting requested review from OleksandrIaresko

@shmo1218 shmo1218 Awaiting requested review from shmo1218

Assignees

@koryaga koryaga

Labels
documentation Improvements or additions to documentation improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexarefev @koryaga @theboringstuff @alku89 @shmo1218