[MANOPD-78395] haproxy maintenance mode #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarefev
force-pushed
the
MANOPD-78395_haproxy_maintenance_check_paas
branch
from
7f84c13
to
49072d8
Compare
theboringstuff
approved these changes
Sep 6, 2022
koryaga
approved these changes
Sep 8, 2022
ilia1243
added a commit
that referenced
this pull request
Oct 25, 2022
1. Fix #216 is partially reverted (changes in check_paas). 2. VRRP IP with maintenance maintenance-type: "not bind" is now skipped when calculating control_plain. 3. Added new patch which migrates the cluster from not bind VRRP IP. 4. Added ability to deviate enrichment of cluster to simplify patch development. 5. Removed unnecessary template haproxy_mntc.cfg.j2 6. Added more rebust verification of haproxy and VRRP configuration. 7. Other minor fixes and refactoring. 8. Added unit tests for control_plain detection.
5 tasks
koryaga
pushed a commit
that referenced
this pull request
Oct 31, 2022
* Skip not bind VRRP IP for control_plain calculation 1. Fix #216 is partially reverted (changes in check_paas). 2. VRRP IP with maintenance maintenance-type: "not bind" is now skipped when calculating control_plain. 3. Added new patch which migrates the cluster from not bind VRRP IP. 4. Added ability to deviate enrichment of cluster to simplify patch development. 5. Removed unnecessary template haproxy_mntc.cfg.j2 6. Added more rebust verification of haproxy and VRRP configuration. 7. Other minor fixes and refactoring. 8. Added unit tests for control_plain detection. * Skip not bind VRRP IP for control_plain calculation Added documentation. * Auto-update license header * Fix unit test * Update Installation.md * Update Installation.md * Decrease requirements to haproxy in maintenance mode 1. Haproxy in maintenance mode not also listens the node's own internal address, if the balancer is not combined with other roles. 2. Now only one VRRP IP (that is 'not bind') is enough for non-HA schemes. * Decrease requirements to haproxy in maintenance mode Added new patch which assigns internal_address for haproxy in maitnenance mode. * Added unit tests * Auto-update license header Co-authored-by: ilia1243 <[email protected]> Co-authored-by: shmo1218 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
check_paasprocedure should work with balancers inmaintenance modeSolution
cluster.yamlfor thehaproxymaintenance mode configuration file preservingservices.haproxy.statustaskHow to apply
Not applicable
Test Cases
TestCase 1
Check if maintenance mode is covered
Test Configuration:
Steps:
maintenance_mode: trueandmaintenance-type: "not bind"forpublic_cluster_iphaproxywith maintenance configuration file on eachbalancernodecheck_paasprocedureResults:
Checklist