Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSUPCLPL-10682] Update calico defaults: disable FELIX_USAGEREPORTINGENABLED #222

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

n549
Copy link
Collaborator

@n549 n549 commented Sep 13, 2022

Description

By default Calico reports anonymous Calico version number and cluster size to projectcalico.org. Logs warnings returned by the usage server. For example, if a significant security vulnerability has been discovered in the version of Calico being used.
Internal environments don't have access to externals sites. For other environments it's also better to disable sending such reports by defaults.

Sending reports can always be enabled via calico plugin envs settings.

Fixes # (issue)
PSUPCLPL-10682

Solution

Set environment variable FELIX_USAGEREPORTINGENABLED: false by default for calico plugin. If necessary, it can be set to true in cluster.yaml.

How to apply

[Re]install calico plugin with deploy.plugins task.

Test Cases

Deploy calico plugin with default settings. After some time check logs of calico-node pods that there are no such strings:

2022-09-08 22:36:51.472 [INFO][11232] felix/usagerep.go 160: Failed to report usage/get deprecation warnings. error=Get "https://usage.projectcalico.org/UsageCheck/calicoVersionCheck?alp=false&alp_policies=0&cal_ver=v3.22.2&guid=782df6cbcafe4920b32d3a49b81a2239&heps=0&k8s_ver=v1.23.6&policies=0&profiles=1429&rev=14cf6d6ea10423b12809d868eb574a9a610916f9&size=34&type=k8s%2Cbgp%2Ckubeadm%2Ckdd%2Ctypha&version=v3.22.2&weps=2020": context deadline exceeded (Client.Timeout exceeded while awaiting headers)

@n549 n549 added the improvement New feature or request label Sep 13, 2022
@n549 n549 changed the title update calico defaults: disable FELIX_USAGEREPORTINGENABLED [PSUPCLPL-10682] Update calico defaults: disable FELIX_USAGEREPORTINGENABLED Sep 13, 2022
@theboringstuff
Copy link
Collaborator

Should we add "How to apply" section to recommend re-installing calico plugin?

@n549
Copy link
Collaborator Author

n549 commented Sep 13, 2022

Should we add "How to apply" section to recommend re-installing calico plugin?

There already is chapter on plugins reinstallation in the documentation: https://github.com/Netcracker/KubeMarine/blob/main/documentation/Installation.md#plugins-reinstallation
We can set/change any env variable in cluster.yaml, mentioning all of them in the docs looks excessive.

@koryaga koryaga merged commit 685a366 into main Sep 15, 2022
@koryaga koryaga deleted the disable_calico_felix_reporting branch September 15, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants