Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Review relating to https://github.com/Netcracker/KubeMarine/pull/596 #603

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

shmo1218
Copy link
Contributor

Description

Please include a summary of the change and describe issue. Please also include relevant motivation and context.
*

Fixes # (issue)

Solution

Describe solution. List all changes that you made during implementation.
*

How to apply

Provide steps how to apply on top previous Kubemarine version to execute on existing clusters

Test Cases

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

TestCase 1

Test Configuration:

  • Hardware:
  • OS:
  • Inventory:

Steps:

Results:

Before After

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

Indicate new or changed unit tests and what they do, if any.

@shmo1218
Copy link
Contributor Author

Hi, @koryaga,

Please take a look and merge the changes. These are relating to #596.

Thanks!

@koryaga koryaga self-assigned this Feb 19, 2024
@koryaga koryaga added the documentation Improvements or additions to documentation label Feb 19, 2024
@koryaga koryaga merged commit def51cc into main Mar 20, 2024
40 of 41 checks passed
@koryaga koryaga deleted the doc_review branch March 20, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants