Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise configuration of pylint and fix/suppress messages #617

Merged
merged 19 commits into from
Apr 12, 2024
Merged

Revise configuration of pylint and fix/suppress messages #617

merged 19 commits into from
Apr 12, 2024

Conversation

ilia1243
Copy link
Contributor

@ilia1243 ilia1243 commented Mar 5, 2024 •
edited
Loading

Description

  • Pylint is run in CI but is useless due to a bulk of messages.
  • It is possible to check some typical problems using pylint and make CI fail if there are any.

Solution

  • Added pylint configuration in pyproject.yaml.
  • Fail CI action if any message is printed.
  • Disable some frequent unimportant messages.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

ilia1243
ilia1243 commented Mar 5, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@koryaga koryaga added the improvement New feature or request label Mar 6, 2024
@koryaga koryaga requested a review from Imadzuma March 6, 2024 08:28
@ilia1243 ilia1243 force-pushed the improvement/pylint_config branch 3 times, most recently from ac1658b to 4dab77c Compare March 7, 2024 15:00
@ilia1243 ilia1243 force-pushed the improvement/pylint_config branch 3 times, most recently from cf95a4d to c0e2cec Compare March 20, 2024 10:28
@ilia1243 ilia1243 requested a review from Imadzuma March 27, 2024 13:00
@koryaga koryaga merged commit 8cce8cb into main Apr 12, 2024
42 checks passed
@koryaga koryaga deleted the improvement/pylint_config branch April 12, 2024 10:15
@ilia1243 ilia1243 mentioned this pull request May 13, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Imadzuma Imadzuma Imadzuma approved these changes

@OleksandrIaresko OleksandrIaresko OleksandrIaresko approved these changes

Assignees

@koryaga koryaga

Labels
improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ilia1243 @Imadzuma @OleksandrIaresko @koryaga