Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPDEV-100505] Always dump finalized inventory for all procedures except do #629

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

ilia1243
Copy link
Contributor

Description

  • After Procedure do does not work #621 cluster_finalized.yaml is not longer dumped in current working directory, if --disable-dump --without-act args are used simultaneously.

Solution

  • Revert the behavior. Introduce context['make_finalized_inventory'] that manages if the cluster_finalized.yaml should be collected and dumped, that is True for all procedures except do.

Test Cases

TestCase 1

Steps:

  1. Run kubemarine install --disable-dump --without-act

Results:

Before After
cluster_finalized.yaml is not collected neither dumped cluster_finalized.yaml is collected and dumped in current working directory only

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

test_run_actions.py - add test to cover cluster_finalized.yaml with the combination of options.

@ilia1243 ilia1243 force-pushed the bugfix/cluster_finalized_disable_dump_without_act branch from a55714a to 79229a3 Compare April 5, 2024 13:13
@vlar0816 vlar0816 changed the title Always dump finalized inventory for all procedures except do [CPDEV-100505] Always dump finalized inventory for all procedures except do Apr 11, 2024
@koryaga koryaga merged commit c27147b into main Apr 12, 2024
42 checks passed
@koryaga koryaga deleted the bugfix/cluster_finalized_disable_dump_without_act branch April 12, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants