Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CPREQ-10003] - deprecated kuber version #690

Merged
merged 9 commits into from
Sep 12, 2024

Conversation

Imadzuma
Copy link
Collaborator

@Imadzuma Imadzuma commented Sep 5, 2024

Description

Kubernetes versions are excluded from support in kubemarine without any warnings (except mentions in release notes).
But user should plan your upgrade to a new version in advance, so should know when the version he is using becomes a deprecated version and will soon be disabled.

Solution

  • Added version deprecation support in compatibility map:
    • Reused supported field to mark version as deprecated;
    • Fixed logs after install/upgrade procedures, warn if version is deprecated;
    • Added new check-paas task, that checks, if version is deprecated;
  • Kubernetes 1.26 is marked as deprecated;
  • Added validation check for sync tool
    • If default version does not exist in compatibility map (should be removed), sync tool fails with exception;
  • Other fixes:

Test Cases

TestCase 1

Test Configuration:

  • Hardware:
  • OS:
  • Inventory: kubernetes 1.26

Steps:

  1. Run kubemarine install;
  2. Run kubemarine check_paas;

Results:

Before After
No warnings Warning in the end, if version is deprecated
Not applicatable New task, that verifies kubernetes version, warns, that version is deprecated

TestCase 2

Steps:

  1. Try to remove 1.28 kubernenes version using sync tool (default version is 1.28.12);

Results:

Before After
Procedure is successfull Procedure fails with an exception

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Integration CI passed
  • Unit tests. If Yes list of new/changed tests with brief description
  • There is no merge conflicts

Unit tests

Indicate new or changed unit tests and what they do, if any.

@koryaga koryaga self-assigned this Sep 6, 2024
Dockerfile Outdated Show resolved Hide resolved
@koryaga koryaga added the improvement New feature or request label Sep 9, 2024
@koryaga
Copy link
Collaborator

koryaga commented Sep 10, 2024

@OleksandrIaresko pls proceed with QA

@koryaga
Copy link
Collaborator

koryaga commented Sep 10, 2024

@disa1217 pls validate respective output

@disa1217
Copy link
Collaborator

@koryaga , reviewed and made a few changes. please check.

@koryaga koryaga merged commit b1a42d1 into main Sep 12, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants