Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renewal of HystrixCommandProperties information reported by HystrixCommandMetrics #822

Closed
TheTweak opened this issue Jun 21, 2015 · 4 comments

Comments

@TheTweak
Copy link

I have a simple custom HystrixPropertiesStrategy that maintains properties cache with time-based eviction, but when some property changes, it is not propagated to HystrixCommandMetric. I haven't found any plugin (tried HystrixMetricsPublisher) setup that allows to invalidate HystrixCommandMetric too.
Hystrix version is 1.3.19

@mattrjacobs
Copy link
Contributor

I'm not 100% sure I understand your use case here. Are you saying that you want a properties strategy which has a TTL on properties?

When a HystrixCommand gets constructed (in both 1.3 and 1.4), the properties are retrieved through the HystrixPropertiesStrategy layer of indirection. So you should be able to model any sort of property algorithm you'd like with a custom HystrixPropertiesStrategy.

I'm not sure what the metrics publishing has to do with properties.

@TheTweak
Copy link
Author

My problem is that after I've implemented TTL on properties using custom HystrixPropertiesStrategy, and when properties are changed, this change is not propagated to HystrixCommandMetrics because HystrixCommandMetrics get properties once it is created, and it cannot be changed.

@mattrjacobs
Copy link
Contributor

I'm pursuing a way to create custom HystrixCommandMetrics instances in #843. This should be possible once that change is done and released

@TheTweak
Copy link
Author

TheTweak commented Aug 7, 2015

Ok, cool, closing it with reference to #843.

@TheTweak TheTweak closed this as completed Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants