Make hystrix metrics abstract #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NetflixOSS » Hystrix » Hystrix-pull-requests #146 SUCCESS |
added 4 commits
July 28, 2015 15:05
- Breaking change to mark* methods visibility (from public -> package-private)
|
NetflixOSS » Hystrix » Hystrix-pull-requests #148 SUCCESS |
This was referenced Aug 3, 2015
|
NetflixOSS » Hystrix » Hystrix-pull-requests #149 SUCCESS |
|
I've just branched off 1.4.x, and this is the first commit past that point into master. Once I am comfortable this works as intended, I will modify the Wiki |
mattrjacobs
added a commit
that referenced
this pull request
Aug 7, 2015
…-abstract Make hystrix metrics abstract
mattrjacobs
added a commit
that referenced
this pull request
Oct 14, 2015
Revert metrics changes from #843
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the concern of #333. This PR is intended to be a PoC to demonstrate that there can be varying implementations of metric collection (command/thread pool/collapser). The version which summarizes via HystrixRollingNumber/HystrixRollingPercentile is one such concrete implementation.
This PR is not ready for merging - I still would like to:
If anyone has feedback along those lines, it would be appreciated.