Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix metrics publishing by caching publisher command instances by both command group key + command key (1.5.x) #1921

Open
wants to merge 1 commit into
base: 1.5.x
Choose a base branch
from

Conversation

ali-jawad
Copy link

@ali-jawad ali-jawad commented Jan 14, 2019

closes #1888

This fixes a bug whereby if two Hystrix commands have the same command key, although different group keys, only one of them will be reported.

Declaration: I agree to license my contribution under the terms of the APLv2.

@ali-jawad ali-jawad changed the title cache publishers for commands by both command group key + command key cache publishers for commands by both command group key + command key (1.5.x) Jan 14, 2019
so that they are unique. This fixes a bug whereby if two Hystrix commands have the same command key, although different group keys, only one of them will be reported.
@ali-jawad ali-jawad force-pushed the caching-publishers-uniquely-1.5.x branch from e7ff313 to abc5893 Compare January 14, 2019 14:05
@ali-jawad ali-jawad changed the title cache publishers for commands by both command group key + command key (1.5.x) fix metrics publishing by caching publisher command instances by both command group key + command key (1.5.x) Jan 14, 2019
@dnsbtchr
Copy link

dnsbtchr commented Nov 4, 2019

Any plans to get this merged soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants