fix issue #338: Make devPhase part of groupName #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change intends to fix #338.
What is unclear to me now is why I have two failures in LoadBalancerControllerTests.groovy:
Cannot invoke method getBean() on null object
java.lang.NullPointerException: Cannot invoke method getBean() on null object
at com.netflix.asgard.LoadBalancerController$_closure5.doCall(LoadBalancerController.groovy:127)
at com.netflix.asgard.LoadBalancerControllerTests.testSaveWithoutMostParams(LoadBalancerControllerTests.groovy:62)
Cannot invoke method getBean() on null object
java.lang.NullPointerException: Cannot invoke method getBean() on null object
at com.netflix.asgard.LoadBalancerController$_closure5.doCall(LoadBalancerController.groovy:157)
at com.netflix.asgard.LoadBalancerControllerTests.testSaveSuccessfully(LoadBalancerControllerTests.groovy:88)
Interestingly, the failure only happens when I run all tests (grails test-app) but not when I run only the LoadBalancerCrontrollerTests, so it looks like there may be an order-dependency somewhere in the tests?