Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new deployment pages #542

Merged
merged 8 commits into from
Apr 18, 2014
Merged

new deployment pages #542

merged 8 commits into from
Apr 18, 2014

Conversation

claymccoy
Copy link
Contributor

new and detail pages for a deployment using AngularJS

@claymccoy
initial content from Yeoman Angular generator
d0666ce
@claymccoy
grunt modifications specific to Asgard
74ee398 
put grunt dist under web-app
remove cruft from index
remove unneeded yeoman files and rev grunt task
add NgController
remove unused css and image tasks
quicker html and js regeneration for grunt watch
use phantomjs rather than chrome for karma tests because it works in Jenkins
junit results for karma tests in build
@claymccoy
grails controller dedicated to angular pages
2451956
@claymccoy
add js dependencies needed for new pages
327385b 
This reverts commit 0910452ee7122e6ee6b91df40a477b70a97f23b7.
@claymccoy
angular 'detail' and 'new' pages for deployment
6907da5
@claymccoy
added comment
80592b5
@cloudbees-pull-request-builder
Copy link

asgard-pull-requests #384 SUCCESS
This pull request looks good

@cloudbees-pull-request-builder
Copy link

asgard-pull-requests #385 SUCCESS
This pull request looks good

@claymccoy
Copy link
Contributor Author

This Cloudbees job executes the JS build before he Grails build:
https://netflixoss.ci.cloudbees.com/job/asgard-node/

Basically these are the changes:
These commands need to run before Grails in order to get the JS dependencies, run the JS unit tests, style checks, and generate the final artifacts that will be bundled in the war.

npm install
bower install
grunt

And adding this as a junit report:
test-results.xml

Note, the JS part of this is basically it's own project that could be separated in the future.

@cloudbees-pull-request-builder
Copy link

asgard-pull-requests #387 SUCCESS
This pull request looks good

aglover added a commit that referenced this pull request Apr 18, 2014
@aglover
Merge pull request #542 from claymccoy/integrateNewDeployPages
38f79a3 
new deployment pages
@aglover aglover merged commit 38f79a3 into Netflix:master Apr 18, 2014
@cloudbees-pull-request-builder
Copy link

asgard-pull-requests #389 SUCCESS
This pull request looks good

@claymccoy
Copy link
Contributor Author

Thanks for merging this in @aglover.
BTW, @joesondow I am very interested in your feedback on this one. Maybe we can finish talking through it and the dev experience. I'll still be happy to make any changes you want.
And @cfieber @tomaslin and @danveloper if you want to tell me how I can better align this with other projects or what I could do better, that is much appreciated.

@joesondow joesondow mentioned this pull request Apr 18, 2014
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@claymccoy @cloudbees-pull-request-builder @joesondow @aglover