optimize validation when using SortedTagMap #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validate variant that allows checking this type without first converting to SmallHashMap. Benchmark was updated and fixed so that validation would pass which is the most common case in actual use. Before it would fail due to the reserved key check. That made the benchmark results misleading as the composite check seemed faster since it was able to short-circuit earlier. For the successful case it was actually slower. Also adds a flag that can be used to choose whether or not to group simple tag rules into a composite. By default it will not as that seems to generally be faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validate variant that allows checking this type without
first converting to SmallHashMap.
Benchmark was updated and fixed so that validation would pass
which is the most common case in actual use. Before it would
fail due to the reserved key check. That made the benchmark
results misleading as the composite check seemed faster since
it was able to short-circuit earlier. For the successful case
it was actually slower. Also adds a flag that can be used to
choose whether or not to group simple tag rules into a
composite. By default it will not as that seems to generally
be faster.